Fix cache inconsistency segfault #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
tstirrat15
force-pushed
the
fix-cache-inconsistency-segfault
branch
from
0a4c384 to
ce17139
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1985
Description
Prior to this fix, you could provoke a segfault by running thumper against a spicedb instance that didn't have a schema in it. It was racy, implying that there was some caching or threading behavior involved, and we added some debug until we found a place where the reader was listing out a nil value that was set as notFound in the cache.
This changes the cache's behavior so that it doesn't list out notFound values, which should prevent this segfault from appearing.
Changes
Testing
Review. See that things are green.